BugFix for unescaped html in shortcodes gets parsed/styled in visual editor #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SH passes unescaped html to the tiny mce editor. The tags are getting parsed and styled by the user-agent in some instances. The reset specifies that children of pre should inherit style.
|
I think I have the same/similar problem as this. I'm using Markdown on Save Improved & Typewriter - Markdown for WordPress An example of my broken page can be found here: You'll see my first snippet of code has spurious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SH passes unescaped html to the tiny mce editor. The tags are getting
parsed and styled by the user-agent in some instances. The reset
specifies that children of pre should inherit some style from pre.
Steps to reproduce:
Example short code
[html]<h1>This is an h1</h1>[html]Expected output:
The user should be able to switch tiny mce modes (text/visual) and the content of the shortcode will consistently be styled with pre in visual mode
Actual Output:
Since SH passes unescaped html to the editor, the html gets parsed by the browser applying user-agent styles and theme editor styles to the h1 tag
Tested with: WordPress 3.6-beta3-24430